[ISSUE #389] Support redis as event store #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjz921024
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the Apache EventMesh (incubating) community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
WeChat Group：
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
|
@jjz921024 Could you please re-submit this feature to branch 1.3.0? since this is a not stable feature, thanks. |
|
@jjz921024 Please rebase from the latest develop branch, the SPI module has been enhanced by #367. |
* remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
close apache#366
…pi (apache#392) * modify:optimize flow control in downstreaming msg * modify:optimize stategy of selecting session in downstream msg * modify:optimize msg downstream,msg store in session * modify:fix bug:not a @sharable handler * modify:downstream broadcast msg asynchronously * modify:remove unneccessary interface in eventmesh-connector-api * modify:fix conflict * modify:add license in EventMeshAction close apache#391
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* remove custom concept{dcn}
* bugfix : miss group set
* bugfix : miss group set
* [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * * update gradle version for instructions * fix: dist task exception * [ISSUE apache#329]Missing Log4j dependency * update eventmesh-runtime.png * support unsubscribe topics while delconsumer in http mode
* [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * * update gradle version for instructions * fix: dist task exception * [ISSUE apache#329]Missing Log4j dependency * update eventmesh-runtime.png * support unsubscribe topics while delconsumer in http mode * [ISSUE apache#397]Remove subscription session failed error * [ISSUE apache#397]Remove subscription session failed error close apache#397
…+** branches (apache#412) close apache#411
* merge develop into 1.3.0 branch (apache#401) * upgrade gradle to 6.8.3 * [ISSUE apache#265]rename wemq and access to eventmesh * [ISSUE apache#265]rename proxy field to eventmesh * merge conflict * remove warn * [ISSUE apache#265] Specification of code structure and file naming * remove eventmesh-registry module * enabled http/tcp monitor logs * Update README.md * Changed com.webank to org.apache Changed 'eventmesh-connector-api' code package name to apache. * issue apache#277:refactor eventmesh-common package with org.apache * issue apache#277:rename package with org.apache * Refactor 'eventmesh-connector-rocketmq' package name to org.apache * Update README.zh-CN.md * [ISSUE apache#282]Refactor 'eventmesh-starter' package name to org.apache * Update codeStyle.xml * Refactor 'eventmesh-test' package name to org.apache apache#283 * Refactor 'eventmesh-test' package name to org.apache apache#283 * Refactor 'eventmesh-test' package name to org.apache apache#283 * Refactor 'eventmesh-test' package name to org.apache apache#283 * Refactor 'eventmesh-test' package name to org.apache apache#283 * refactor runtime module package com.webank to org.apache * refactor(eventmesh-sdk-java):rename to org.apache(apache#281) * [ISSUE apache#281]refactor(eventmesh-sdk-java):rename to org.apache * add licenses of apache for runtime module * add NOTICE * bugfix for event-mesh-test module * change package name to org.apache * format README.md * change package name to org.apache * fix ISSUE apache#296:add licenses in each source file under the eventmesh-sdk-java * [ISSUE apache#294]add licenses in file under eventmesh-connector-rocketmq module * [ISSUE apache#293]Lack of licenses in each source file under the eventmesh-connector-api module * [ISSUE apache#298]Lack of licenses in each source file under the eventmesh-test module * [ISSUE apache#297]Lack of licenses in each source file under the eventmesh-starter module * Create .asf.yaml * Update .asf.yaml * Update .asf.yaml (apache#316) * Update README.md * Update .asf.yaml * bugfix build.gradle tar task (apache#318) Co-authored-by: jonyang(杨军) <jonyang@webank.com> * [ISSUE apache#322] Rename package name "com.webank.eventmesh" to "org.apache.eventmesh" (apache#319) * rename org.apache.runtime to com.webank.runtime * rename com.webank.eventmesh to org.apache.eventmesh * fix(docs): change the travis location * Create DISCLAIMER-WIP * Delete CNAME * Delete _config.yml * Delete package.json * Add files via upload * Add files via upload * Delete eventmesh-multi-runtime.jpg * Update README.md * Update eventmesh-runtime-quickstart.md * Update README.zh-CN.md * Update eventmesh-runtime-quickstart.zh-CN.md * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository (apache#326) * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * upgrade gradle to 7.0 and fix test bug. (apache#327) * bugfix build.gradle tar task * merge * upgrade to gradle 7.0 * bugfix gradle task spotbugs * bugfix eventmesh-connector-rocketmq testImplementation * upgrade to gradle7.0 * refactor runtime module test and spotbugs error * bugfix sign task Co-authored-by: jonyang(杨军) <jonyang@webank.com> Co-authored-by: jonyangx <jonyang1120@gmail.com> * remove unused files Signed-off-by: qqeasonchen <qqeasonchen@gmail.com> * update build.gradle and gradle.properties for publish to maven repository (apache#330) * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * Update README.md * Update README.zh-CN.md * update quickstart md files for gradle version (apache#332) * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * * update gradle version for instructions * fix: dist task exception * remove dead docs Signed-off-by: qqeasonchen <qqeasonchen@gmail.com> * [ISSUE apache#329]Missing Log4j dependency (apache#336) * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * * update gradle version for instructions * fix: dist task exception * [ISSUE apache#329]Missing Log4j dependency * [ISSUE apache#331] Fix dead links in docs (apache#334) fixed apache#331 * Doc modification apache#328 (apache#335) change vm params * Update README.md * [Issue apache#337] Fix Http Test Subscriber startup issue by moving the Thread.sleep into the child thread (apache#338) * [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit Co-authored-by: j00441484 <jin.rong.luo@huawei.com> * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook (apache#343) * [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Address code review comment for Subscriber Demo App Co-authored-by: j00441484 <jin.rong.luo@huawei.com> * [ISSUE apache#348] Setup automated workflows for greetings (apache#347) * Setup automated workflows for greetings * Remove '@apache/eventmesh-committers' * Add LGTM Badges ISSUE#353 (apache#354) LGTM is a variant analysis platform that automatically checks code for real CVEs and vulnerabilities. Learn more at https://lgtm.com/help/lgtm/about-lgtm . Here are some alerts in our project reported by LGTM: https://lgtm.com/projects/g/apache/incubator-eventmesh/alerts/?mode=list I'd like to add LGTM badges in the README.md, it makes easier for people who want to get alerts and then contribute to EventMesh. * [ISSUE apache#355] Setup Github workflows for CodeQL scans (apache#356) * Setup CodeQL scans * disable autorun * add a step for setting up JDK * add codeql * fix step Build * fix strategy * add events: schedule & workflow_dispatch * [Issue apache#344] Fixing racing condition issue in SubscribeProcessor and UnSubscribeProcessor (apache#345) * [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#344] Fixing racing condition issue in SubscribeProcessor and UnSubscribeProcessor * [Issue apache#344] Fix import statements * [Issue apache#337] Address code review comment for Subscriber Demo App * [Issue apache#344] Enhance client registration logic in SubscribeProcessor and UnsubscriberProcessor * [Issue apache#344] Minor code clean up in SubscribeProcessor and UnsubscriberProcessor * [Issue apache#344] Fix NullPointerException in ConsumerManager occurs during subscribe/unsunscribe iteration testing * [Issue apache#344] Fix bugs in subscribe/unsunscribe code path * [Issue apache#344] use client.pid instead of client.ip for client comparasion in UnSubscribeProcessor Co-authored-by: j00441484 <jin.rong.luo@huawei.com> * update eventmesh-runtime.png (apache#358) * update eventmesh-runtime.png * [Issue apache#333] Support multiple load balance strategy in sdk (apache#342) * Support multiple load balance strategy in sdk apache#333 * Fix ut * add log * update eventmesh-panels.png (apache#362) * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * * update gradle version for instructions * fix: dist task exception * [ISSUE apache#329]Missing Log4j dependency * update eventmesh-runtime.png * update eventmesh-panels.png * update eventmesh-panels.png (apache#363) * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * * update gradle version for instructions * fix: dist task exception * [ISSUE apache#329]Missing Log4j dependency * update eventmesh-runtime.png * update eventmesh-panels.png * Migrate CI to Github Actions and enable coverage report (apache#365) * add: requirements for lightweight EventMesh SDK with CloudEvents (apache#370) This commit only includes a brief introduction and requirements. Design details can be followed up in a later commit. Signed-off-by: Yuzhou Mao <myz@umich.edu> * Add files via upload * Update README.md * [Issue apache#368] Fix Racing condition and memory leak issue in EventMesh SDK LiteConsumer and LiteProducer (apache#369) * [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Address code review comment for Subscriber Demo App * [Issue apache#368] Fix Racing condition and memory leak issue in EventMesh SDK LiteConsumer and LiteProducer * [Issue apache#368] fix build issue * [Issue apache#368] use try with resource statement for HttpClient * [Issue apache#368] fix TLS1.1 and use TLS1.2 in HttpClient Co-authored-by: j00441484 <jin.rong.luo@huawei.com> * [ISSUE apache#350]optimize flow control in downstreaming msg (apache#352) * modify:optimize flow control in downstreaming msg * modify:optimize stategy of selecting session in downstream msg * modify:optimize msg downstream,msg store in session * modify:fix bug:not a @sharable handler * [ISSUE apache#380] Remove gitee-mirror.yml from Github workflows (apache#381) * Update README.md * [ISSUE apache#310] add github action for check license (apache#313) * add github action for check license * fix syntax and name ci for Check license * fix github action branch typo * [ISSUE apache#310] Enable Github Actions for license check and fix license headers (apache#377) * add github action for check license * fix syntax and name ci for Check license * fix github action branch typo * enable github actions for license check * add necessary headers * update badges Co-authored-by: Lan Liang <gcslyp@gmail.com> * [Issue apache#382] Fix java.lang.NumberFormatException when parsing Long (apache#383) * [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Address code review comment for Subscriber Demo App * [Issue apache#368] Fix Racing condition and memory leak issue in EventMesh SDK LiteConsumer and LiteProducer * [Issue apache#368] fix build issue * [Issue apache#368] use try with resource statement for HttpClient * [Issue apache#368] fix TLS1.1 and use TLS1.2 in HttpClient * [Issue apache#382] Fix java.lang.NumberFormatException when parsing Long * [Issue apache#382] Fix java.lang.NumberFormatException when parsing Integer Co-authored-by: j00441484 <jin.rong.luo@huawei.com> * [ISSUE apache#378] downstream broadcast msg asynchronously (apache#379) * modify:optimize flow control in downstreaming msg * modify:optimize stategy of selecting session in downstream msg * modify:optimize msg downstream,msg store in session * modify:fix bug:not a @sharable handler * modify:downstream broadcast msg asynchronously closed apache#378 * [ISSUE apache#359] Split handler from controller (apache#359) (apache#360) * [ISSUE apache#359] Split handler from controller (apache#359) * add license header * add ut * [ISSUE apache#384] RedirectClientByIpPortHandlerTest.java doesn't have the Apache license header (apache#385) close apache#384 * Update README.md * Update README.zh-CN.md * Update README.zh-CN.md * Update README.zh-CN.md * [Issue apache#386] fixing ConsumerGroup Queue Consumer Offset not synced up issue (apache#387) * [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Address code review comment for Subscriber Demo App * [Issue apache#386] fixing ConsumerGroup Queuen Consumer Offset not synced up issue * [Issue apache#386] adding license header to new file * [Issue apache#386] Fix license header missing issue Co-authored-by: j00441484 <jin.rong.luo@huawei.com> * [ISSUE apache#366 ] remove custom-format topic concept (apache#388) * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * remove custom-format topic concept * [ISSUE apache#366] remove custom concept [dcn&®ion] (apache#390) * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} close apache#366 * [ISSUE apache#391] Optimize interface design in eventmesh-connector-api (apache#392) * modify:optimize flow control in downstreaming msg * modify:optimize stategy of selecting session in downstream msg * modify:optimize msg downstream,msg store in session * modify:fix bug:not a @sharable handler * modify:downstream broadcast msg asynchronously * modify:remove unneccessary interface in eventmesh-connector-api * modify:fix conflict * modify:add license in EventMeshAction close apache#391 * miss group name set for userAgent (apache#395) * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * remove custom concept{dcn} * bugfix : miss group set * bugfix : miss group set * [ISSUE apache#393]:perf topic name in test file (apache#394) close apache#393 * support unsubscribe topics while delconsumer in http mode (apache#396) * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * * update gradle version for instructions * fix: dist task exception * [ISSUE apache#329]Missing Log4j dependency * update eventmesh-runtime.png * support unsubscribe topics while delconsumer in http mode * [ISSUE apache#397]Remove subscription session failed error (apache#398) * [ISSUE apache#325]Update gradle configuration for publishing package to maven repository * update build.gradle * update build.gradle and gradle.properties * update build.gradle and gradle.properties for publish to maven repository * * update gradle version for instructions * fix: dist task exception * [ISSUE apache#329]Missing Log4j dependency * update eventmesh-runtime.png * support unsubscribe topics while delconsumer in http mode * [ISSUE apache#397]Remove subscription session failed error * [ISSUE apache#397]Remove subscription session failed error close apache#397 Co-authored-by: jonyang(杨军) <jonyang@webank.com> Co-authored-by: MajorHe1 <hefan1007@gmail.com> Co-authored-by: mike_xwm <mike_xwm@126.com> Co-authored-by: Eason Chen <qqeasonchen@gmail.com> Co-authored-by: Heng Du <duhengforever@apache.org> Co-authored-by: Udesh Liyanaarachchi <> Co-authored-by: keranbingaa <397294722@qq.com> Co-authored-by: sunxi <sunxi_mail@163.com> Co-authored-by: sanchen <san@chenyiliu.com> Co-authored-by: surilli(李慧敏) <surilli@webank.com> Co-authored-by: Lan Liang <gcslyp@gmail.com> Co-authored-by: zhangxiaopengmm <xiaopeng_521a@163.com> Co-authored-by: nanoxiong <xiong_mengfei@163.com> Co-authored-by: chenyi19851209 <409696597@qq.com> Co-authored-by: yangjun <yangjun1120@gmail.com> Co-authored-by: Steve Yurong Su <steveyurongsu@outlook.com> Co-authored-by: von gosling <vongosling@apache.org> Co-authored-by: jonyangx <jonyang1120@gmail.com> Co-authored-by: ruanwenjun <861923274@qq.com> Co-authored-by: jinrongluo <kapoking@gmail.com> Co-authored-by: j00441484 <jin.rong.luo@huawei.com> Co-authored-by: Yuzhou Mao <yuzhou.myz@gmail.com> Co-authored-by: lrhkobe <34571087+lrhkobe@users.noreply.github.com> Co-authored-by: Steve Yurong Su <rong@apache.org> Co-authored-by: Lan <liangyuanpengem@163.com> * [ISSUE apache#411] Enable CI workflows running on [0-9]+.[0-9]+.[0-9]+** branches (apache#413) * [Issues apache#405]code polish and fix typo (apache#404) * code polish and fix typo * merge remote 1.3.0 * [ISSUE apache#374] Add unit test class. (apache#402) * [ISSUE apache#374] add unit test for LiteMessage class. * [ISSUE apache#374] add unit test for HttpCommand class. * [ISSUE apache#374] add unit test for httpResponse method with REQ cmd type. * [ISSUE-apache#374] Add unit test class. (apache#414) * [ISSUE apache#374] add unit test for CommonConfiguration class. * [ISSUE apache#374] add unit test for ConfigurationWraper class. * [ISSUE apache#374] add unit test for Weight class. * [ISSUE apache#374] add unit test for CommonConfiguration class. * [ISSUE apache#367]Enhance SPI plugins (apache#419) * [ISSUE apache#374] add unit test for http protocol header client class. (apache#420) * fix typo (apache#423) * [ISSUE apache#418]Refactor the plugin load code (apache#421) * [ISSUE apache#418]Refactor the plugin load code * fix ut * [ISSUE apache#405]modify the doc (apache#424) * modify the doc * modify the doc * Merege 1.3.0 to develop. * Merege 1.3.0 to develop. * Merge 1.3.0 to develop, fix check style problem. Co-authored-by: wqliang <wqliang@users.noreply.github.com> Co-authored-by: jonyang(杨军) <jonyang@webank.com> Co-authored-by: MajorHe1 <hefan1007@gmail.com> Co-authored-by: mike_xwm <mike_xwm@126.com> Co-authored-by: Eason Chen <qqeasonchen@gmail.com> Co-authored-by: Heng Du <duhengforever@apache.org> Co-authored-by: keranbingaa <397294722@qq.com> Co-authored-by: sunxi <sunxi_mail@163.com> Co-authored-by: sanchen <san@chenyiliu.com> Co-authored-by: surilli(李慧敏) <surilli@webank.com> Co-authored-by: Lan Liang <gcslyp@gmail.com> Co-authored-by: zhangxiaopengmm <xiaopeng_521a@163.com> Co-authored-by: nanoxiong <xiong_mengfei@163.com> Co-authored-by: chenyi19851209 <409696597@qq.com> Co-authored-by: yangjun <yangjun1120@gmail.com> Co-authored-by: Steve Yurong Su <steveyurongsu@outlook.com> Co-authored-by: von gosling <vongosling@apache.org> Co-authored-by: jonyangx <jonyang1120@gmail.com> Co-authored-by: ruanwenjun <861923274@qq.com> Co-authored-by: jinrongluo <kapoking@gmail.com> Co-authored-by: j00441484 <jin.rong.luo@huawei.com> Co-authored-by: Yuzhou Mao <yuzhou.myz@gmail.com> Co-authored-by: lrhkobe <34571087+lrhkobe@users.noreply.github.com> Co-authored-by: Steve Yurong Su <rong@apache.org> Co-authored-by: Lan <liangyuanpengem@163.com> Co-authored-by: YuDong Tang <583125614@qq.com>
* enable github actions for checkstyle * try to fix ci * ... * ... * ... * Enable Github Actions for Checkstyle * accelerate * -filter-mode=nofilter -fail-on-error * remove -name
* fix typo * fix typo
* The Chinese in the notes is translated into English. * Translation improvement * Translation improvement * fix Chinese annotation on runtime module
* [ISSUE apache#367] Support prototype spi instance change producer and consumer spi to prototype * rename test method
…he#443) * fix findings in RequestCode * fix findings in ClientRetCode * fix findings in Async* * fix findings in eventmesh-runtime * translate all chinese * translate * fix findings in org.apache.eventmesh.spi.example * move package demo to org.apache.eventmesh.runtime.demo * translate * rename package client to org.apache.eventmesh.runtime.client * rename package client to org.apache.eventmesh.runtime.client * update checkStyle.xml * fix System.err.out * delete sChat2 * remove comments in eventmesh-sdk-java:build.gradle * remove Chinese in eventmesh-test:build.gradle * fix Chinese findings in tcp_sub_broadcast.sh * fix Chinese findings in *.sh
* [ISSUE apache#367] Refactor connector 1.support load plugin from eventMeshPluginDir 2.remove connector plugin from runtime * Add docs of plugin * Remove connector-api in connector-plugin
|
@jjz921024 Could you please submmit this feature to branch redis-connector? |
I have open a another pr #478 for submmit this feature. In this pr, i seem megre some irrelevant commit due of my mistake, sorry about that. |
|
#478 is duplicate with this, so close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#389
Motivation:
Modifications: